tools: run Linux tests on GitHub arm64 runners as well #57162
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
What kind of burden reduction are you talking about? If anything, adding more things increases the maintenance burden rather than reducing it – which is worth it as long as it improves the reliability of Node.js IMO, but still an increase of maintenance burden |
aduh95
approved these changes
Feb 21, 2025
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-24.04, ubuntu-24.04-arm] |
There was a problem hiding this comment.
nit: we could go back to ubuntu-latest now that it's an alias for ubuntu-24.04 IIUC
Suggested change
| os: [ubuntu-24.04, ubuntu-24.04-arm] | |
| os: [ubuntu-latest, ubuntu-24.04-arm] |
There was a problem hiding this comment.
IMO it's better to be explicit and choose when we want to switch to 26.04. We had issues with automated updates in the past (new compiler may not work with the main branch).
anonrig
approved these changes
Feb 22, 2025
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7174ec9 |
acidiney
pushed a commit
to acidiney/node
that referenced
this pull request
Feb 23, 2025
PR-URL: nodejs#57162 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions now supports native Linux arm64 runners for public projects: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/
If I understand it correctly, your current Jenkins pipeline only tests on Ubuntu 22.04 for Linux arm64. Using the new
ubuntu-24.04-armrunner adds Ubuntu 24.04 to the mix, and even 22.04 could be considered by addingubuntu-22.04-arm, which might help reduce the maintenance burden on the team.